search

djangoflow / list_bloc

BLoC management of simple, filtered, sorted and paged lists.
3 stars 10 forks source link

feat [list_cubit]: add remove, add & replace #29

Closed cscoderr closed 1 year ago

cscoderr commented 1 year ago

This address https://github.com/djangoflow/list_bloc/issues/18 pls leave a comment

adar2378 commented 1 year ago

Thanks, I will get back to your PR soon.

adar2378 commented 1 year ago

@cscoderr You haven't answered my questions yet, why did you use Future in the methods?

cscoderr commented 1 year ago

@adar2378 Future is not needed there cause it does not perform any asynchronous task so i have remove it in the latest PR

adar2378 commented 1 year ago

@adar2378 Future is not needed there cause it does not perform any asynchronous task so i have remove it in the latest PR

Hi, you still haven’t answered why did you add it in the first place.

cscoderr commented 1 year ago

@adar2378 Future is not needed there cause it does not perform any asynchronous task so i have remove it in the latest PR

Hi, you still haven’t answered why did you add it in the first place.

okay i copied the function from the existing functions and replicate the rest the same way

adar2378 commented 1 year ago

@cscoderr Thank you for submitting your Pull Request. After careful consideration and review, we regret to inform you that we will not be accepting your changes at this time. I would encourage you to pay more attention to the details while writing code so you can avoid unwanted return types or mistakes like that.

While we appreciate the effort you put into your application, we have decided it is not a good fit for our project's goals and requirements. We encourage you to keep working on your skills to continue contributing to open-source projects and keep an eye out for our new opening in the future.

We understand that receiving negative feedback can be disappointing, but please know that this decision does not reflect your abilities or potential. We encourage you to take this as an opportunity to learn and grow from the experience and try again in future.

Thank you again for your time and effort in submitting your Pull Request, and we wish you all the best in your future endeavors, Cheers.