search

djangoflow / list_bloc

BLoC management of simple, filtered, sorted and paged lists.
3 stars 10 forks source link

[flutter_list_bloc] Added widget tests for bloc builder widgets #31

Closed aniketambore closed 1 year ago

aniketambore commented 1 year ago

Hello! I've made some additions to the flutter_list_bloc package in response to issue #19 regarding integration and widget tests for the bloc builder widgets.

I focused on implementing widget tests for the bloc builder widgets. Widget tests are an appropriate choice for this package project since it primarily involves testing the behavior and rendering of individual widgets in response to bloc state changes (empty, loading, error, or data). These tests verify that the bloc states are accurately reflected in the widget tree and ensure proper widget behavior.

Regarding the mention of integration tests, I think that integration tests are typically used for complete application project, where they simulate user interactions and verify the overall flow of the app. However, since flutter_list_bloc is a package project that mainly focuses on individual widgets and how they integrate with the bloc, I just wanted to confirm if there is a need for integration tests in this context?

Widget tests effectively cover the desired behavior by allowing us to test the interactions of individual widgets in response to bloc state changes.

Fixes #19

adar2378 commented 1 year ago

@aniketambore I think there should be a test for ‘ContinuousListViewBlocBuilder’ regarding pagination. Like pagination worked and new items were added. Also another for ‘reload’ method that the items were reloaded properly. You can mimic the fetching more item and reloading implementing some additional methods. Otherwise looking good

aniketambore commented 1 year ago

@adar2378 Thank you for your feedback and suggestions!

In response to your comment, I have added two new test cases to cover the pagination and reload functionality of the ContinuousListViewBlocBuilder. The tests simulate the fetching of additional items and the reloading of the list, ensuring that the expected behavior is correctly implemented.

Please review the pull request and let me know if you have any further suggestions or if there are any other areas that you would like me to focus on.

adar2378 commented 1 year ago

@aniketambore Thank you for the updates, I will go through it and will get back to you within Monday.

adar2378 commented 1 year ago

@aniketambore Overall, the widget tests look good for widget tests. Thank you. Reach out on Slack if you need to discuss things. But I feel like we need some sort of integration tests to verify that the widgets are working expectedly, especially for the ContinuousListViewBlocBuilder

adar2378 commented 1 year ago

@aniketambore Thank you. Great work. Please follow up on my comments if you have any questions regarding them. Other than that I think I don't have any other improvements to be make at the moment, cheers.