search

djangoindia / djangoindia.org

Official website of djangoindia community.
https://djangoindia.org
MIT License
106 stars 48 forks source link

[FEATURE] Add lint check on pre-commit for front end #207

Open salty-ivy opened 4 weeks ago

salty-ivy commented 4 weeks ago

Summary

Currently We lack lint checks on front end such as prettier

Description

prettier can be added to pre-commit-config.yaml and need some additional configurations.

References

https://prettier.io/docs/en/

Use Case

No response

Alternatives

No response

Affected Area

Frontend

nitin-1926 commented 3 weeks ago

I would like to work on it. Please assign it to me.

DevilsAutumn commented 3 weeks ago

I am not sure if its a valid issue rn, we don't have proper linting rules configured since https://github.com/djangoindia/djangoindia.org/pull/116 is still WIP. IMO, It would be better to get this done after we have proper rules and configurations for frontend.

@Saurabhsharma884 @nitin-1926 thoughts?

nitin-1926 commented 3 weeks ago

Makes sense @DevilsAutumn . We should let that merge first and then see again if this is required and to what extent. That way it will be more streamlined.

salty-ivy commented 3 weeks ago

I think once eslint would be integrated, all that would be left is to add it in pre-commit-config.yaml.

Its up to rest of us to decide that task would be considered big enough to have its own issue ticket.

DevilsAutumn commented 3 weeks ago

Agreed. But Let not close this issue and wait for #116 to complete.

29deepanshutyagi commented 2 weeks ago

i want to work on this issue ,kindly assign me @DevilsAutumn