search

djangonaut-space / wagtail-indymeet

Djangonaut Space site
MIT License
13 stars 9 forks source link

Talwind build error due to !important #338

Closed MHLut closed 3 months ago

MHLut commented 3 months ago

The manage.py tailwind build command fails with the following error:

CssSyntaxError: /Users/mhlut/Webserver/wagtail-indymeet/theme/static_src/src/djangonaut-space.css:68:101: Unknown word
    at Input.error (/Users/mhlut/Webserver/wagtail-indymeet/theme/static_src/node_modules/postcss/lib/input.js:106:16)

This error originates from the keyword #{!important} in @apply, under the .social-link selector. Remove the former, and the error disappears.

According to https://github.com/tailwindlabs/tailwindcss/discussions/10799, you can apply the Tailwind important modifier to the relevant utility instead.

The important tag was added a couple of days ago for #327, but I can't see why it's needed. The style seems OK on localhost. Can we remove it again?

RachellCalhoun commented 3 months ago

Good catch! I also ran into this yesterday but forgot to followup 😅 . Thanks! @sarahboyce might have more insight. I think we definitely need to change/remove it.

tim-schilling commented 3 months ago

I think it's because without it the social media icons weren't showing up. They were all purple.

MHLut commented 3 months ago

I think it's because without it the social media icons weren't showing up. They were all purple.

I think that one actually got fixed in the next PR that Sarah merged shortly after, which is #328.

tim-schilling commented 3 months ago

If that's the case, then it can likely be removed.

sarahboyce commented 3 months ago

I don't think I've properly fixed it still but yes you can remove the #{!important} 👍