if value_annot[key] is boolean, then issubclass(value_annot[key] raises exception

djangonauts / django-hstore

PostgreSQL HStore support for Django.

http://django-hstore.readthedocs.io/

Other

517 stars 142 forks source link

if value_annot[key] is boolean, then issubclass(value_annot[key] raises exception #100

Closed i2xS closed 9 years ago

i2xS commented 9 years ago

subj.

TypeError: issubclass() arg 1 must be a class

So we need to switch order of conditions.

landscape-bot commented 9 years ago

Code quality remained the same when pulling 783f400 on i2xS:master into cb6830a on djangonauts:master.

coveralls commented 9 years ago

Coverage remained the same at 92.35% when pulling 783f400b66e5e35bc3887ffc4d694920010140ea on i2xS:master into cb6830a9475ca124c19552d7625456b2ef76373a on djangonauts:master.

coveralls commented 9 years ago

Coverage remained the same at 92.35% when pulling 783f400b66e5e35bc3887ffc4d694920010140ea on i2xS:master into cb6830a9475ca124c19552d7625456b2ef76373a on djangonauts:master.

nemesifier commented 9 years ago

Hi @i2xS, thank you for contributing. Before mergin patches, we always add failing test cases. What's the procedure to replicate the bug you're experiencing? Federico

i2xS commented 9 years ago

Ok, sorry. PR with test here https://github.com/djangonauts/django-hstore/pull/102

landscape-bot commented 9 years ago

Code quality remained the same when pulling 783f400 on i2xS:master into eff0d84 on djangonauts:master.

landscape-bot commented 9 years ago

Code quality remained the same when pulling 783f400 on i2xS:master into c36546b on djangonauts:master.