search

djangonauts / django-hstore

PostgreSQL HStore support for Django.
http://django-hstore.readthedocs.io/
Other
517 stars 142 forks source link

Without dict.get() method this part can raise Exception #134

Closed svfat closed 8 years ago

svfat commented 8 years ago

Without dict.get() method this part can raise Exception if the database haven't 'ENGINE' key for some reason

landscape-bot commented 8 years ago

Code Health Code quality remained the same when pulling 614d32f on svfat:master into 3b235cb on djangonauts:master.

nemesifier commented 8 years ago

@svfat could you point to me the part of the django documentation where it says having a database without the ENGINE key is allowed?

nemesifier commented 8 years ago

Since this check is done on all databases, even those ones which do not concern django-hstore it makes sense to be forgiving.