search

djangonauts / django-hstore

PostgreSQL HStore support for Django.
http://django-hstore.readthedocs.io/
Other
517 stars 142 forks source link

Django110 support #151

Closed jarekwg closed 8 years ago

jarekwg commented 8 years ago

The Creator class disappears in Django 1.10 along with the removal of the subclassing module. This is a bit of a naive way to keep django-store dj110 compatible, but maybe someone can suggest a nicer approach.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 87.859% when pulling f4321925f98841f6f0fcb1d9b7d4393e269ee3d4 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

nemesifier commented 8 years ago

Hi @jarekwg, so far there are no comments. So yours is the best solution proposed until now. Could you add django 1.10b to the travis configuration file too? Let me know. Federico

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 87.859% when pulling ab682d334fda3165169374c344444fe8f25da5b4 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 87.859% when pulling ad0d935416ed25a83ea108afa34552d55285e4ca on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 87.859% when pulling 995b61d572567f8e49be3abd89e576ad589c24c1 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 87.859% when pulling 1f3d3db3332c7ab4466b2e813d2022d76c255253 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 87.859% when pulling 0c7b8df6b89b0661aeb85192108802584c225ae1 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

jarekwg commented 8 years ago

Hrm, looks like there's a lot of stuff that's changed. My original PR only fixed the part that was breaking for my project. I guess I'll try to update it to address all of the deprecations.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.7%) to 87.321% when pulling 1276bcb55c203c9b49601434cf976a3ae544ba51 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.6%) to 87.349% when pulling 4b05de955a24e75dcdf38d9e47cc290c5e1d69a0 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.07%) to 87.899% when pulling 4b05de955a24e75dcdf38d9e47cc290c5e1d69a0 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.07%) to 87.899% when pulling aeaab80e2fc7a350a7a22ad41f987f401c7a98a2 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.09%) to 87.885% when pulling 561ff00aa89cde5496af63a3068a297e534fae7d on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.09%) to 87.885% when pulling 56a1f53e20166ddf29ba97fe6e99a753fba5c9aa on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

jarekwg commented 8 years ago

Still needs addressing (in case anyone wants to join in):

See the failing travis tests for more info.

nemesifier commented 8 years ago

Thanks @jarekwg, I can't look into these issues right now, but I'm sure someone will step in soon if I am not fast enough.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.9%) to 86.044% when pulling d59ccb3c6b5b8604814999c4572a1b37928469c7 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

jarekwg commented 8 years ago

Hrm, I think it'd be nice to swap out HStoreField for django's one (available since 1.8, see commit d59ccb3). It'd make updating to django 1.10 easier, but certain things would need to be rearranged to have it playing nicely with the rest of this package (see failing tests corresponding to d59ccb3).

This would of course mean this package is only good with postgres, but it's currently only being tested against postgres anyway so...

Let me know your thoughts.

For the project I'm working on I was initially considering just scrapping use of django-hstore altogether and using django's HStoreField directly, but you do some pretty sweet schema magic here.

jarekwg commented 8 years ago

Also, these coveralls comments are annoying. The check down the bottom of the PR already covers all of the same information.

aleccool213 commented 8 years ago

updates on this?

jarekwg commented 8 years ago

Hi, So I think for this PR, I'll just revert the latest commit and we can merge the rest in. This'll make most of django-hstore compatible with django110, with this exception of SerializedDicts, which can be addressed in a separate PR.

My more drastic proposal of essentially converting django-hstore into "django-schema-magic" by offloading all of the hstorefield work to django's HStoreField can be discussed in a separate issue.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.09%) to 87.885% when pulling 694bdb0c91e6a4f4e5331c6bce6f9ee8d24b4e98 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.09%) to 87.885% when pulling 20b47a963226c79bcdee33003808c9a7a3bde724 on jarekwg:upgrade/django110 into 277b28cbd92f358c6edcd7ea2022bbcdb680de56 on djangonauts:master.

jarekwg commented 8 years ago

Hey @nemesisdesign, Any chance you could review&merge this?

It addresses most of the changes that came with dj110. The tests say that ReferencesField and SerializedDictionaryField are still broken, but if people aren't using these, the rest should run fine in production against dj110.

I don't have time to fix the remaining failures currently, so I've put dj110 in allowed failures. The rest can be fixed in a separate PR later.

Cheers,

aleccool213 commented 8 years ago

+1 this

nemesifier commented 8 years ago

thanks @jarekwg, I'm also interested in the idea of offloading the HStore internals to django, although helping people to migrate could be hard.

The ReferenceField may go into a separate app. In the truth the VirtualField machinery also could be a separate app.

rajaramsrn commented 7 years ago

I need this fix badly. Currently on 1.5a0 off github. I notice last release was more than 6 months back. Any tentative date for release 1.5 ?

Cheers

nemesifier commented 7 years ago

@rajaramsrn the build is still broken: https://travis-ci.org/djangonauts/django-hstore; can you fix it? If yes we'll publish a new release straightaway. I have no resources to work on this right now. Let me know.