search

djangonauts / django-hstore

PostgreSQL HStore support for Django.
http://django-hstore.readthedocs.io/
Other
517 stars 142 forks source link

Widget not working in Admin TabularInline #23

Closed ipmb closed 10 years ago

ipmb commented 10 years ago

The form field breaks inlines in the admin.

nemesifier commented 10 years ago

sorry haven't had time yet to check and fix, will do as soon as I can

nemesifier commented 10 years ago

So if you click on "add row" it does not add any row?

could not reproduce this issue, I'm on django 1.6.1 using a StackedInline.

Which configuration are you using? Any javascript error in the developer console?

Could you please upgrade to the latest commit I just pushed (https://github.com/djangonauts/django-hstore/commit/050ae1ad37ad9a8111d51fc8fcf93c486c0a862d), run the test application in your browser and try to reproduce the issue there?

If you manage to reproduce the issue you can send a pull request and then I'll setup the same env as yours.

unbracketed commented 10 years ago

Thanks for your efforts. It still isn't working properly. When I try to add a new inline object, there's no dropdown for selecting the model instances. For rows that have already been added, we used to have labels showing which instance was used. I'll dig deeper when I have a free moment and/or post an example demonstrating the problems.

ipmb commented 10 years ago

The project we're seeing this on is actually all open source: https://github.com/BotBotMe/botbot-web.

Could it be the custom through table causing issues?

unbracketed commented 10 years ago

It works OK if we change the inline type to StackedInline (was using TabularInline) screenshot 2014-02-13 14 27 35

With TabularInline we don't have ability to select model or tell which row is which. This is the result after hitting "Add another" a few times:

screenshot 2014-02-13 14 34 16

We'll go forward with the StackedInline for now. Thanks for looking into this.

nemesifier commented 10 years ago

Ok, I'll open another ticket for the TabularInline issue. We'll brainstorm if it's worth to try a fix or not.

nemesifier commented 10 years ago

Changed my mind and just renamed this ticket