Use local underscore.js #90 instead of CDN

djangonauts / django-hstore

PostgreSQL HStore support for Django.

http://django-hstore.readthedocs.io/

Other

517 stars 142 forks source link

Use local underscore.js #90 instead of CDN #91

Closed GregUK closed 9 years ago

GregUK commented 9 years ago

Update to use local underscore.js rather than cdn version, used version 1.7 of underscore

coveralls commented 9 years ago

Coverage remained the same when pulling d6b75d980da592966b9a68b800782b36240b3c07 on GregUK:master into c2714b7b66f2650ce0e5af17229e40a1d96f3edb on djangonauts:master.

nemesifier commented 9 years ago

Hey man this is simply wrong, did you even test this?

landscape-bot commented 9 years ago

Repository health increased by 6% when pulling d6b75d9 on GregUK:master into c2714b7 on djangonauts:master.

5 new problems were found (including 0 errors and 5 code smells).
55 problems were fixed (including 52 errors and 2 code smells).

nemesifier commented 9 years ago

@GregUK i tested this patch a few months ago and it had issues which it caused not to work properly. If you are going to work to fix this let me know.