Add conf module + make JSON encoder overridable

djangonauts / django-pgjson

PostgreSQL json field support for Django

http://djangonauts.github.io/django-pgjson/

Other

131 stars 39 forks source link

Add conf module + make JSON encoder overridable #22

Closed davidfischer-ch closed 9 years ago

davidfischer-ch commented 9 years ago

And other goodies.

niwinz commented 9 years ago

hi @davidfischer-ch

thank you very much for your contributions, but you PR implies adding an external dependency and I'm not clearly convinced adding it. The idea of plugable parser is awesome but with appconf dependcy I can not accept the PR as IS.

Can you remove it and use settings directly instead of appconf?

davidfischer-ch commented 9 years ago

Hi @niwinz

I will remove it next week

niwinz commented 9 years ago

Great!

davidfischer-ch commented 9 years ago

That's it.

niwinz commented 9 years ago

Already merged manually! Thanks!