search

djangopackages-zz / djangopackages

Django Packages - a place to review Django apps, frameworks, and projects.
http://djangopackages.com
MIT License
53 stars 40 forks source link

Lots of progress on the package-comparison grid #103

Closed jimallman closed 13 years ago

jimallman commented 13 years ago

Clean up invalid table markup. Remove duplicate element IDs. Freeze column widths when using smart grid. Add toggle button to switch between smart grid and simple table.

audreyfeldroy commented 13 years ago

Lots of good work in this commit, but sadly enough bugs that it's not quite production-ready yet. See images below. If you can fix what I marked in the screenshots and resubmit, I'll accept the pull request. Chrome 9 (Windows 7) http://skitch.com/audreyr/rwi5r/dp-grid-bugs-ec9462c IE 8 (Windows 7)http://skitch.com/audreyr/rwi58/dp-grid-bugs-ec9462c-2

jimallman commented 13 years ago

Audrey,

Thanks for all your help in the sprint! Sorry I had to leave so early.

On Mar 14, 2011, at 5:53 PM, audrey wrote:

Lots of good work in this commit, but sadly enough bugs that it's not quite production-ready yet. See images below. If you can fix what I marked in the screenshots and resubmit, I'll accept the pull request.

OK, thanks for taking a look. I'll dig into these problems and follow up shortly (still getting settled in here).

=jimA=