djangopackages-zz / djangopackages

Django Packages - a place to review Django apps, frameworks, and projects.
http://djangopackages.com
MIT License
53 stars 40 forks source link

http://github.com/ojii/django-login-as breaks add-package form javascript #14

Closed ojii closed 13 years ago

ojii commented 14 years ago

When putting 'http://github.com/ojii/django-login-as' as repo-url, the slug and pypi-slug field get filled with 'django-login-' instead of 'django-login-as'

audreyfeldroy commented 13 years ago

I just tried to repro this and saw it exactly as described in Chrome (8.0.552.215 beta, Ubuntu). In Firefox (3.6.13, Ubuntu) the slug and pypi-slug do not get filled with anything. Looking into it now.

audreyfeldroy commented 13 years ago

The problem is that URLify removes anything in removelist = ["a", "an", "as", "at", "before", "but", "by", "for", "from", "is", "in", "into", "like", "of", "off", "on", "onto", "per", "since", "than", "the", "this", "that", "to", "up", "via", "with"];

audreyfeldroy commented 13 years ago

Fixed by creating a new function DPSlugify that doesn't remove words from removelist.