djangopackages-zz / djangopackages

Django Packages - a place to review Django apps, frameworks, and projects.
http://djangopackages.com
MIT License
53 stars 40 forks source link

Empty bitbucket account results in a long package list #32

Closed vdboor closed 13 years ago

vdboor commented 14 years ago

When the bitbucket account is empty, my profile displays a long list of packages, suggesting I've written those.

pydanny commented 14 years ago

I can't reproduce that error. When I visit your Django Packages page (http://djangopackages.com/profiles/profile/vdboor/) I can't generate the problem. Can you link to the page that is showing this issue?

vdboor commented 14 years ago

I've changed my bitbucket account from "-" back to "", and now you can see it:

http://djangopackages.com/profiles/profile/vdboor/

psam44 commented 13 years ago

Problem is that the default value 'null' in the Profile fields is replaced by an empty string at the first edit form the user. (note that a null=True on a char field is a bad idea - refer to the django doc)

Empty values should be better managed.

But for a quick repair, in apps / profiles / models.py : change bitbucket_regex = r'^%s,|,%s,|%s$' % (name, name, name) to bitbucket_regex = r'^%s,|,%s,|,%s$' % (name, name, name)

and change github_regex = r'^%s,|,%s,|%s$' % (name, name, name) to github_regex = r'^%s,|,%s,|,%s$' % (name, name, name)

(add a ',' before the $)

pydanny commented 13 years ago

Done!