search

djangopackages-zz / djangopackages

Django Packages - a place to review Django apps, frameworks, and projects.
http://djangopackages.com
MIT License
53 stars 40 forks source link

Ticket 20 and Ticket 60 fixes. #87

Closed jamespacileo closed 13 years ago

jamespacileo commented 13 years ago
ptone commented 13 years ago

Just FYI, I think my merged branch already fixed #60 a different way, by trying to do a proper sort of the version number, where as the 'created' may not represent the true order (an older version could be added to the DB after a newer one)

see: https://github.com/djangopackages/djangopackages/commit/9610393e5893e71aad44f8f9df69b7cbb2e93b60

Also, I learned this the hard way too, but since pull requests include all commits on a branch (even those made after the initial pull), its easier for project maintainer if each fix is on its own branch with its own pull request.

jamespacileo commented 13 years ago

Ok, I understand also I probably should wrap Ticket 20 changes with a few exception handlers, even though it seems to work fine when there are no commits attached to a package.

By the way, I think we should edit the ordering of the Version model, as ordering by 'number' does not really work out.