djaodjin / djaopsp

Practices Survey Platform - Assess against best practices assessment and improvement planning
BSD 2-Clause "Simplified" License
3 stars 6 forks source link

Cannot determine assessment from URL #388

Closed smirolo closed 3 years ago

smirolo commented 3 years ago

Screen Shot 2020-10-20 at 9 37 53 AM

I recommend that this page's URL be /app/{organization}/assess/{sample}/{path}/. The page at URL /app/{organization}/assess/{sample} should redirect directly to /app/{organization}/assess/{sample}/{path}/ if there is only one segment in the sample, else present options to the user to pick which segment to go to. That's what the Django implementation does.

quiaro commented 3 years ago

@smirolo per your comment in https://github.com/djaodjin/envconnect/issues/349, it seems that a sample would always be tied to at least one industry for the purposes of displaying it in the UI. If the sample weren't tied to an industry segment, the response from updates would be an empty array and to the UI, this would be the same as not having any active assessments. In other words, the URL /app/{organization}/assess/{sample} does not seem practical for UI purposes because it would result in a redirect or require more information from the user. It would seem better to have /app/{organization}/create/ instead, to denote the path where an assessment is being created and once created the user would be redirected to its corresponding /app/{organization}/home/{sample}/{path}/ path that would serve as the assessment home. Keep in mind that /app/{organization}/assess/{sample}/{path}/ is the URL for completing the assessment. Let me know if you have any thoughts or questions around these URLs.

quiaro commented 3 years ago

@smirolo per our meeting: /app/{organization}/assess/ -create a new assessment /app/{organization}/assess/{sample}/{path} -assessment landing page