search

djay / covidthailand

Thailand Covid testing and case data gathered and combined from various sources for others to download or view
126 stars 15 forks source link

Shorter Thai population formatter #86 #108

Closed modiholodri closed 2 years ago

modiholodri commented 2 years ago

vac_groups_all

djay commented 2 years ago

What if we put the numbers under each other? Also wondering if it makes more sense to put % first?

modiholodri commented 2 years ago

What if we put the numbers under each other? Also wondering if it makes more sense to put % first?

The numbers are already under each other. My bad that I didn't add the screenshot to the PR (maybe actual file even better). I would say it makes sense to put the % first and will also look optically nicer... 👍

I'll change it also in that PR...

modiholodri commented 2 years ago

@djay Moved the % on top. Very hard to say if it look optically better and it looks more like a same same but different case... 😉

I'll also add real rounding to this PR, because it might look strange when the actual numbers are shown on the right side of the chart.

djay commented 2 years ago

@modiholodri sorry didn't see the pic for some reason. looks good. ready to merge?

modiholodri commented 2 years ago

@djay The picture was not there the first time. ;-) Should be ready to merge...