search

djay / covidthailand

Thailand Covid testing and case data gathered and combined from various sources for others to download or view
126 stars 15 forks source link

Update theme to match website #134 #135

Closed modiholodri closed 2 years ago

modiholodri commented 2 years ago

positivity_area_all cases_ages_all cases_prov_decreasing_all

djay commented 2 years ago

@modiholodri try not to do so many different things in one PR. if I squash then the commit message is wrong. If I merge then there are too many commits.

modiholodri commented 2 years ago

@djay I am trying to and actually there are many of them in there from previous PRs. Somehow, I guess I'm doing something wrong. Was the same case with a previous PRs... 🙄

djay commented 2 years ago

@modiholodri did you change the plots to grey or the website to black? isn't website to black going to be better as its higher contrast?

netlify[bot] commented 2 years ago

❌ Deploy Preview for practical-ritchie-cca141 failed.

🔨 Explore the source changes: a96e835ce1b8861b9589b4e95e47eeceabb186b6

🔍 Inspect the deploy log: https://app.netlify.com/sites/practical-ritchie-cca141/deploys/617625061a8d270007d436c2

modiholodri commented 2 years ago

@modiholodri did you change the plots to grey or the website to black? isn't website to black going to be better as its higher contrast?

I am only working on the plots and not touching the web site. It might be the best to change everything to the Default Dark GitHub theme. Then it would be working in the Readme, the Wiki and on the website... I could not change the background before, so it was just black, but now I can...

image

djay commented 2 years ago

@modiholodri there is css to change the website to black. In the end there is no point changing the plots to grey if black is the better option. Which is the better option to look at?

modiholodri commented 2 years ago

@djay I would say it'll look best if we make the figure background the same as the Default Dark GitHub background and the plot background somewhere in the middle between black and background. We could merge this PR so that we can see how it looks like and use it for a while and then make make another one to change it?