search

djay / covidthailand

Thailand Covid testing and case data gathered and combined from various sources for others to download or view
126 stars 15 forks source link

add dep for jekyll build #148

Closed djay closed 2 years ago

netlify[bot] commented 2 years ago

✔️ Deploy Preview for practical-ritchie-cca141 ready!

🔨 Explore the source changes: 9b9fd1b3b76a5dbb2bd218613aa3345fd6b600ba

🔍 Inspect the deploy log: https://app.netlify.com/sites/practical-ritchie-cca141/deploys/617624d31e109c0007d8305e

😎 Browse the preview: https://deploy-preview-148--practical-ritchie-cca141.netlify.app

djay commented 2 years ago

Seems like netlify's python support is pretty shit and doesn't let you pick something > 3.8. Lucky we don't actually need to run the code https://github.com/netlify/build-image/blob/focal/included_software.md

djay commented 2 years ago

@reduxionist its now building but not in a way to puts the readme as the default page or maybe doesn't make this files at all. If you can work out how to make this work it would help with all these visual PRs even before we switch hosting. Although I'm not sure how to solve the image uploading. For that to work we'd need to somehow do a 2nd netlify deploy once the images are ready. We'd also have to add an extra netlify deploy step that changes all the image urls to relative ones so that the github default readme works with absolute urls (to netlify prod or the wiki?) while any preview build shows its own images. ... or... give up on having a readme on github that shows graphs. Keep teh readme as just a explanation and move the site with graphs to just one url on netlify.

reduxionist commented 2 years ago

@djay Okay, understood!