search

djay / covidthailand

Thailand Covid testing and case data gathered and combined from various sources for others to download or view
126 stars 15 forks source link

Show last values for all plots #152

Closed modiholodri closed 2 years ago

modiholodri commented 2 years ago

vac_top5_doses_2_all

Missing for 4 plots...

active_severe_all

netlify[bot] commented 2 years ago

❌ Deploy Preview for practical-ritchie-cca141 failed.

🔨 Explore the source changes: 32a8617de05e658f4cac4396badf81087a099ddd

🔍 Inspect the deploy log: https://app.netlify.com/sites/practical-ritchie-cca141/deploys/6179f20232a58300072fea19

djay commented 2 years ago

@modiholodri bit confused by the PR title. I think my suggestion to show actual values what I meant was in the case where we show MA what we could do is on the right have two numbers. e.g. cases 215 (200avg) or 215/200 with an explanation showing VAL/AVG. Since this will take less space.

modiholodri commented 2 years ago

@djay Yeah, it's confusing. Maybe we should fix the definitions. That's how I see it at the moment... Actual - The value at the end of the line or patch. (Not the axis grid values.) Current - The current value (not average). Average - The rolling average. Relative - In percent. Absolute - In units.

Your suggest makes sense. The thing is that formatters just take a single value and not two basically "independent" values. So you would have to tell me how to get the value pairs. Or maybe just show the average and the current lines as it is done already in some plots, then both could be shown. No value is shown at the moment and it's also not in the legend (probably all lines should be in the legend)... image

Another idea could also be to show the relative and absolute values for more plots similar to the population formatter.