search

djay / covidthailand

Thailand Covid testing and case data gathered and combined from various sources for others to download or view
126 stars 15 forks source link

fix download link in readme.md #158

Closed wasdee closed 3 years ago

wasdee commented 3 years ago

fix download links in readme.md

netlify[bot] commented 3 years ago

❌ Deploy Preview for practical-ritchie-cca141 failed.

🔨 Explore the source changes: 56b485b9ee2aee80bf564ca18c246510be319fe0

🔍 Inspect the deploy log: https://app.netlify.com/sites/practical-ritchie-cca141/deploys/617ceae9aef7070007c41baa

wasdee commented 3 years ago

I just found out that links work on the GitHub readme.md(previously fail with 404, link to this page) , but it might fail on the website.

wasdee commented 3 years ago

I could not check the site since it fails due to dependency. #148 this might already address this.

if it fails, is there anyway to replace str from ](downloads) -> ](downloads.md) before deployment.

So, we could have the links work anywhere.

wasdee commented 3 years ago

this might be the way to make the replacement on README.md

djay commented 3 years ago

Thanks for the pr. The problem is to have it working for both the website and the readme which this would break the website. I think we decided we would remove the readme version and just have the website once we switched it to netlify.

djay commented 3 years ago

Where would you add that template tag in order to make it work?

If you can help with jekyll it would be very useful. it's not something I know.

wasdee commented 3 years ago

I'm not sure if the template tag works too, I'm new to Jekyll. I need to identify and inspect the Jekyll build script. and maybe I could insert a pre-build script like bash sed or python str.replace

if you think it is doable, you could reopen the pr.