search

djay / covidthailand

Thailand Covid testing and case data gathered and combined from various sources for others to download or view
126 stars 15 forks source link

bad data in positive rate province data in moph_dashboard_prov.csv #172

Closed djay closed 2 years ago

djay commented 2 years ago

e.g.

2021-07-06,Khon Kaen,21.0,0.0,0.0,0.0,4.0,0.0,0.0,134.0,621.429,0.0,0.0,0.0
2021-07-06,Krabi,4.0,3.0,0.0,28.0,290.0,0.0,0.0,0.234064592265025,229.0,0.0,0.0,0.0

130.0 is clearly wrong and other provinces at this date and others are equally wrong.

This code is supposed to go back and redownload and correct this. It worked locally but not sure why it hasn't worked in actions.

"Positive Rate Dash": (d("2021-05-20"), last_pos_rate, 0.001, 2), # Might have to remove it completely.

need to either work out why server isn't working or just reupload inputs.tar.gz with local version thats fixed.

djay commented 2 years ago

Might be fixed in https://github.com/djay/covidthailand/commit/f99e511a82ce923bc9573b61d08f27f96e1e5c40. Seems there is a race condition where any fixes to moph_dashboard_prov are lost because the trends is using teh same file and ends up combining and old version and gets priority. Since it was likely run sequentially locally this wasn't a problem.

djay commented 2 years ago

yes that fixed it