Add right side axis labels #73

[modiholodri]

Add axis labels also to the right side of all charts to make them easier to read.

[reduxionist]

Hi,

A regularly scheduled workflow action is currently in progress and we don't like to hit the govm't sources too heavily simultaneously. I'll approve the workflow run for the PR once the current workflow completes, and @djay can then then review accordingly.

Thanks for the PR! 😄

[modiholodri]

@reduxionist No worries and it should be checked carefully. Was my first PR ever and somehow I have the feeling that something went wrong somewhere... ;-)

[reduxionist]

@reduxionist No worries and it should be checked carefully. Was my first PR ever and somehow I have the feeling that something went wrong somewhere... ;-)

I don't see that anything went wrong, but djay will do the real check. Since this is your first PR ever, congratulations and double the thanks!

You might like to know about an alternate workflow for amending PRs; instead of reverting and creating a whole new commit, you can just change the file as is, git add it, git commit --amend, and then git push --force (for an as-yet unmerged PR like this). For me this is a faster workflow, but use whichever fits your head better! 😉

[modiholodri]

@reduxionist Concerning the Formatting Provider, it is set to autopep8, but I lost the squiggly lines and did not figure out yet how to get them back. Basically, all my VS Code Python settings are still the default setting. Just installed Python yesterday and was also my first Python code ever...

[reduxionist]

Yeah, I am new to vscode too (former PyCharm, current vim user tbh) so can't help you getting the squigglies back. Congrats on your first Python code though; it's got a great learning curve so you'll find it easier to get up to speed than with some other languages!

This build failed on our known issue, so nothing to worry about. Just give djay time to fix bugs I can't and then get to PR reviews in queue... 🙇🏿‍♂️

[djay]

@modiholodri looks great. I'll merge it. One addition that would me good is that I use a custom formatter called human_formatter which puts the M/K etc on the numbers. One downside is that its not yet smart enough to get rid of the decimal place if it never shows whole numbers, which ends up taking up more room esp now its on both sides. If you want a next challenge, working this out would be great. And after friday it will count toward hacktoberfest too!

[modiholodri]

@djay Ok, I actually wanted to improve the formatter already and make some other little improvements to make the charts look nicer, like fixing the title. I'll open two issues. Can you assign me to them, because I can't do it myself? Add: Just saw that you have opened an issue already...

[reduxionist]

p.s. Congrats on the merger of your first ever PR! 🍾 👏🏿

Keep it up and I'm sure you'll find it as rewarding as I do... 😄

[modiholodri]

@reduxionist Thanks! 😊 Feels quite good. The plan is to make another one this weekend...