djay0529 / mdanalysis

Automatically exported from code.google.com/p/mdanalysis
0 stars 0 forks source link

New reader class (trz) #152

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
https://code.google.com/r/richardjgowers-testclone/

Adds support for a new format (.trz) which caters for IBIsCO and YASP 
simulation packages.
Also included are unit tests and documentation for the new stuff.

Original issue reported on code.google.com by richardjgowers on 16 Aug 2013 at 10:56

GoogleCodeExporter commented 9 years ago
Richard,

I pushed your code to the branch feature-trzreader and conducted a code review:
https://code.google.com/p/mdanalysis/source/detail?r=4dfb783203c9d2bd610aa4b4c63
18be43ff4e6c5

This lists the issues that need to be changed for the code to be ready to go 
into the development branch.

I made you the owner of this issue (btw, thanks for creating the issue report). 
Make pull requests by posting an issue comment.

Good work!
Oliver

Original comment by orbeckst on 16 Aug 2013 at 6:31

GoogleCodeExporter commented 9 years ago
Ok, I think I've fixed everything.

https://code.google.com/r/richardjgowers-testclone/

trzreader branch of that should include everything (reader, tests and docs)

Original comment by richardjgowers on 19 Aug 2013 at 2:07

GoogleCodeExporter commented 9 years ago
Richard,

Thanks, I checked it and all looked good so I merged it into develop. (Just 
added some docs.) I deleted the feature-trz branch on gcode. 

Oliver

Original comment by orbeckst on 23 Aug 2013 at 1:55