search

djberg96 / sys-proctable

A cross-platform Ruby interface for gathering process information on your operating system
Apache License 2.0
150 stars 33 forks source link

Skip 0 byte pseudo kernel processes #106

Closed rwaffen closed 1 year ago

rwaffen commented 2 years ago

Fixes: #105

djberg96 commented 2 years ago

Extra bonus points if you can integrate https://github.com/vmactions/solaris-vm :)

rwaffen commented 1 year ago

i did the change with rescue. and added as a poc the solaris GHA. i think we have to look how complicated it can get to have a descent ruby up and running in there.

djberg96 commented 1 year ago

Thanks for the update and taking a stab at the github action. However, it looks like it failed. I see The process '/bin/bash' failed with exit code 1.

djberg96 commented 1 year ago

I don't think we need the ruby -v command do we?

Beyond that, looking at the details I see Package runtime/ruby-26 not in catalog. Exiting.

It's up to you if you would like to continue to pursue this, I certainly won't make it a requirement for the main fix. I just thought it would be nice to have, especially since I could then crib from it for other projects. :)

rwaffen commented 1 year ago

ruby -v is only for testing which version would be installed, if it would install at all 🤦 but i would say we split this, first fixing the issue and than separately trying to get this GHA working. will remove the part in the yaml or comment it out for the moment, so we than can continue later on.

djberg96 commented 1 year ago

Ok, go ahead and remove it (or comment it out) and I'll re-run the jobs (which I understand won't actually be testing this change), then I'll merge it. :)