djblue / portal

A clojure tool to navigate through your data.
https://djblue.github.io/portal/
MIT License
888 stars 82 forks source link

Remember ViewColumn between opens #161

Closed PEZ closed 1 year ago

PEZ commented 1 year ago

This makes it so that when you move the Portal view somewhere, it will be opened there next time. The Calva Output/REPL window behaves like this and people seem happy with it. =)

Fixes #160

NB: With this PR I also have added some hot reload infra structure for registering and deregistering disposables, so that we don't need to restart the extension host to add or remove commands, event handlers and other disposables. This is what I do in my extensions, and I thought I would add the event for saving the view column as a global disposable. But then it turned out that it was an event attached to the WebView panel instance... Let me know if you want to have a cleaner PR without this change.

djblue commented 1 year ago

@PEZ thanks for this awesome update! ❤️