djblue / portal

A clojure tool to navigate through your data.
https://djblue.github.io/portal/
MIT License
872 stars 81 forks source link

Support vega-lite :datasets key as well as :data #192

Closed athos closed 1 year ago

athos commented 1 year ago

Currently, the vega-lite viewer requires the data key in the selected value. However, the Vega-Lite specification doesn't actually require it, and the datasets field is sometimes useful rather than data (especially when you have an individual dataset for each layer).

This PR proposes to relax the current spec of the vega-lite viewer and change it so that it can accept either of the data or datasets key.

djblue commented 1 year ago

@athos thanks for the PR! I've never seen the or syntax in a keys spec, good to know 👍

djblue commented 1 year ago

@athos This should now be available in 0.46.0!

athos commented 1 year ago

Thanks for the quick release!