search

djblue / portal

A clojure tool to navigate through your data.
https://djblue.github.io/portal/
MIT License
872 stars 81 forks source link

Bug with test reporting and Portal middleware #208

Closed seancorfield closed 8 months ago

seancorfield commented 8 months ago

Definitely an edge case: in HoneySQL, there's a test that uses an unhashable Object to test a specific equality check and it "breaks" Portal.

Repro case here: https://github.com/seancorfield/portal-bug-repro

I tracked it as far as the clojure.test interceptions that Portal's middleware puts in place. Hope the repro case is helpful!

djblue commented 8 months ago

Thanks for the repro case! I think https://github.com/djblue/portal/commit/486bcc59ed8dff56a4deec3a3d27bf93c1f5ba92 should resolve the issue.

seancorfield commented 8 months ago

Nice! Thank you.