djblue / portal

A clojure tool to navigate through your data.
https://djblue.github.io/portal/
MIT License
872 stars 81 forks source link

Replace t/report with t/do-report #209

Closed mrkam2 closed 7 months ago

mrkam2 commented 7 months ago

clojure.core/report is a multimethod that can't be redefined using with-redefs. It looks like the closest thing that we can do is to redefine a clojure.test/do-report which also receives all the error data.

djblue commented 7 months ago

Thanks for the PR @mrkam2! I didn't know about do-report. It's too bad the defn isn't dynamic, then I could also use it here https://github.com/djblue/portal/blob/master/src/portal/nrepl.clj#L111.