Include port in websocket url when host is specified

djblue / portal

A clojure tool to navigate through your data.

https://djblue.github.io/portal/

MIT License

872 stars 81 forks source link

Include port in websocket url when host is specified #228

Closed momerath42 closed 3 months ago

momerath42 commented 3 months ago

When providing the host option to portal/open, the websocket url provided to javascript lacks the port, resulting in: Uncaught (in promise) DOMException: Failed to construct 'WebSocket': The URL 'ws://<ip>:NaN/rpc?<uuid>' is invalid.

Fix as suggested by djblue

djblue commented 3 months ago

@momerath42 were you able to test out if this solution fixed your issue?

momerath42 commented 3 months ago

Yes; tested and fixed my issue.