search

djblue / portal

A clojure tool to navigate through your data.
https://djblue.github.io/portal/
MIT License
865 stars 81 forks source link

Add support for brave-browser as chrome-bin #68

Open bsless opened 2 years ago

bsless commented 2 years ago

Hello, I'm starting to use Portal and encountered a slight inconvenience, it does not recognize Brave browser Brave is another chromium based browser which can probably be used just like the other executables found by get-chrome-bin, and supports launching in app mode. The linux executable is called brave-browser, not sure regarding other operating systems.

Thanks

bsless commented 2 years ago

As a temporary workaround I symlinked chromium to brave

djblue commented 2 years ago

@bsless This sounds like a good inclusion. Would you mind submitting a PR with the proposed change?

bsless commented 2 years ago

@djblue Gladly, though I don't have OSX or Windows so I won't be able to test it there, but I'll give it a best effort. Also, would you like to add any action or setting for default browser? A user might have one installed but prefer portal opens with the other.

djblue commented 2 years ago

No worries, I can test out those platforms. That's a good point about different browser choices. What do you think the option should look like?

bsless commented 2 years ago

open can take an option for preferred browser which would be looked for first, :portal.launcher/browser? In the same vain, an option to save these configuration and have portal automatically search for them would also be nice. in *nix systems you can place a file in XDG_CONFIG_PATH, with windows it's always a riddle. Then users won't need to specify browser, color, or other preferred options.

bsless commented 2 years ago

Thinking some more about browsers, especially if you want to make it "future proof", it might be a good idea to have some data spec for browsers and how portal consumes them. Things like the executable name on each operating system, extra paths to search in, supported operating systems, web engine, etc. That might make life easier when the next user wants to add specific support for Edge, Opera, or a new browser (optimistic, I know)

yannvanhalewyn commented 2 months ago

I'm really enjoying Portal :). I would also like something like this: I would like to be able for Portal to open in Arc browser on Mac, which is another Chromium based browser. Now I let it open in Chrome, copy the URL and close Chrome.