Refactor setup.py

[jupadin]

Change Types

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

1) Improved the youth detection of leagues for '-F-' or '-M-' (see models.py:69) 2) Handling the resulting exception thrown by this (see setup.py:202) 3) Added logic to skip 'Freundschaftsspiele' (see setup.py:181) 4) Removed duplicate associations due to url filtering and improved url concatenation (see parsing.py:24)

• Bugfix 1
• Could not initialize app due to missing games for season 2022 / 2023 and name comparison (see models.py:45).
• Fixed by checking
  • what did not work before?
  • what happens now instead?
• Steps to reproduce
  1. Call setup and check whether data is ingested.

Checklist

• [ ] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read CONTRIBUTING.md.
• [ ] I have added tests to cover my changes.
• [ ] My tests run automatically.
• [ ] All new and existing tests passed.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[djbrown]

Thanks you for the PR though! 😉 I really appreciate your work to improve the project, especially this biggest and most complex module. The comments may seem harsh or nitpicky, but I'm just making sure I undestand the changes and only needed changed are introduced. Also I changed the change type to from feature to bugfix, since the PR only fixes specific cases without introducing new use cases.

[jupadin]

Hi,

yes, might be too much changes to be declared as a PR. If okay, we could just close this PR and I would have a look on the current branch / commit and see how I can integrate the adjustments more clearly. In your last commit, I also saw the change of the Root-URL -:)