djbrown / hbscorez

HbScorez is a web application, which processes handball game reports of diverse handball associations, districts, and leagues. It analyzes the player scores and displays the statistics and rankings.

https://hbscorez.de

MIT License

19 stars 3 forks source link

Refactored district parsing routine #118

Closed jupadin closed 1 year ago

jupadin commented 1 year ago

Change Types

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Code Refactoring

Description

Instead of scraping the html content of each individual association, this PR uses the response of an PHP-Script, given the association id (bhv_id). The data returned by the script is handled as JSON.
Started testing this new routine by adding a unit test.
This partly improves the issue #77

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read CONTRIBUTING.md.
[x] I have added tests to cover my changes.
[ ] (?) My tests run automatically.
[x] All new and existing tests passed.

djbrown commented 1 year ago

thanks for the @jupadin! I didn't know that SPO-Endpoint yet. Why did you close this? I'd have a look into this 😉

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information