search

djbulsink / panasonic_ac

Panasonic Comfort Cloud HA component
30 stars 16 forks source link

HomeKit Automation #12

Closed J-Bland closed 5 years ago

J-Bland commented 5 years ago

First thanks for the awesome work, I’ve got 9 split units setup on this working well.

I do also have them pushed to HomeKit and this also for the most part works really well. There’s no fan speed but I can think that’s a Home Assistant issue.

However when trying to set an automation to turn off the AC when leaving if I forget it actually turns it on even if it was off. I suspect looking at the list of changes that it might be down to HomeKit probably sending a temp at the same time as turning the mode to off. I see a commit that turns the devices on if they were off from a change like that so might be causing it.

Any change you have HomeKit as well to look into this to see if it’s solveable?

J-Bland commented 5 years ago

I've fixed this myself by removing the Power on from when the temp is set so it was as I thought.

So removed it from this function:

def set_temperature(self, **kwargs):

Not sure though if you want that gone as it also changes how Home Assistant works as obviously it doesn't turn on until you tell it the mode, moving the temp slider won't power it on anymore. However to have HomeKit Automation be able to switch the AC off, this is required.

djbulsink commented 5 years ago

Hi @FastLaneJB ,

Good catch. Although removing the Power on from this function is a breaking change, it is imho an improvement. I'll change the function.

J-Bland commented 5 years ago

Thanks, much appreciated:)