Accept trailing comma in array

djc / askama

Type-safe, compiled Jinja-like templates for Rust

Apache License 2.0

3.5k stars 221 forks source link

Accept trailing comma in array #1097

Closed aquarhead closed 2 months ago

aquarhead commented 2 months ago

Fix #1086

aquarhead commented 2 months ago

Just FYI you can allow other jobs in a matrix to run to complete instead of cancel when one of them fails https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast (it defaults to true)

I don't think the failure is related to my change?

djc commented 2 months ago

That's right, the failure is unrelated. If you're able to add a separate commit that changes the matrix to allowing it to complete, that would be great!

djc commented 2 months ago

Test failure addressed in #1098.