Closed Wilkuu-2 closed 9 months ago
Ok, now please run cargo fmt
and then squash your commits.
@GuillaumeGomez if there is a single conceptual change we don't need the submitter to squash -- we can just "Squash and merge" instead.
Ah true. I keep forgetting about it.
Thanks!
fixed an issue for me that almost made me swap to a different templating engine before i saw this thread! thank you all :D
Hello, I recently decided to switch from Tera to Askama, and I'm enjoying it so far.
Yesterday, I stumbled upon issue #719 and decided to see if I can fix the issue with the markdown filter, so I don't have to include Comrak in my own crate as a workaround. What I found out is that the issue with using
String
is that the filter moves the value out of the struct. This is fine for&str
considering&str
is already a reference.Making the generated code borrow the value did not create any problems in tests.
This PR also adds a test for passing
String
s to the markdown filter and simplifies the function signature for the filter to accept&str
.