djc / gcp_auth

Minimal authentication library for Google Cloud Platform (GCP)
Other
63 stars 38 forks source link

Add support for impersonation to the CustomServiceAccount impl #106

Closed djc closed 7 months ago

djc commented 7 months ago

Less invasive replacement for #92.

@zhrebicek sorry it took me a while to get back to this, are you still interested? I think this could do the job, any thoughts? (The meat of the change here is in the last commit, feel free to ignore the refactoring before that.)

@nrempel does this address your use case?

(Note that there exists an impl TryFrom<CustomServiceAccount> for AuthenticationManager.)

zhrebicek commented 7 months ago

I did not have much time to come back to it. I will try to test it within days and let you know.

Thanks!

zhrebicek commented 7 months ago

@djc gave it a go and it works for my use-case. Thanks :)

djc commented 7 months ago

@zhrebicek sorry for the long wait -- thanks for the quick feedback!

Published gcp_auth v0.11.1 at registry crates-io.