djc / imap-proto

IMAP protocol parser and datastructures in Rust
12 stars 2 forks source link

CommandBuilder quotation #17

Closed cyphar closed 6 years ago

cyphar commented 6 years ago

There is a quotation bug in CommandBuilder -- we aren't applying IMAP4 quotation to passwords which is a mistake because passwords can contain " and \ (which result in parsing errors on IMAP4 servers). The solution would be to just apply the same quotation that Python's imaplib does (I've also implemented it in my own tool).

djc commented 6 years ago

Nice catch, thanks for reporting! I'll take a look soon to figure out how to fix it (unless you want to take a swing at it?).