search

djc / instant-epp

MIT License
7 stars 6 forks source link

Feature request: serde derives/implementations behind a feature flag #48

Open gibbz00 opened 1 month ago

gibbz00 commented 1 month ago

The move from quick-xml to instant-xml limited interop between other serialization formats.

I'm wondering if it would be appreciated if I send in a PR that derives SerializeDeserialize for types that implement ToXml and DeserializeSerialize for types that implement FromXml.

We're building an interface for EPP, and not having to create DTOs of practically the same structure makes the process a lot easier. Granted, some custom serialization will still be need.

djc commented 1 month ago

What do you need interoperability with other serialization formats for?

gibbz00 commented 1 month ago

The first step is to build an REST-ish API server that translates commands from a simpler format such as JSON.

gibbz00 commented 1 month ago

There are some of course some country/business specifics that need to be accounted for. Still, having most implementations upstream feels more appropriate.

djc commented 1 month ago

I'm open to this in principle, but given that this is somewhat niche and will be a larger effort to review, I think this really needs some support mechanism in place (as discussed in #47). Happy to discuss what that could look like on a call or via email.