djc / rnc2rng

RELAX NG Compact to regular syntax conversion library
MIT License
16 stars 13 forks source link

Support tilde token for concatenation of string literals #12

Closed wamuir closed 6 years ago

wamuir commented 6 years ago

My read of the RELAX NG Compact Syntax spec indicates that two string literals should be concatenated when immediately surrounding a tilde. This is not currently supported by rnc2rng but could be useful. As one example, Appendix B to RFC 4278 (ATOM syndication) utilizes several tildes and concatenation would be expected. PR to include support in parser.py and add a simple test.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 89.815% when pulling 89290eb29bf9a3b5c6ca0fae3c72b15c24cee957 on wamuir:master into 27ec83871a945d5a9295563c28f133208a7a0ba0 on djc:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 89.815% when pulling 89290eb29bf9a3b5c6ca0fae3c72b15c24cee957 on wamuir:master into 27ec83871a945d5a9295563c28f133208a7a0ba0 on djc:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 89.815% when pulling 71fb31344298a7bb3eece0bb10ffcd564476818c on wamuir:master into 27ec83871a945d5a9295563c28f133208a7a0ba0 on djc:master.

wamuir commented 6 years ago

Great, thanks! I made the operator change (left a comment on the first) and squashed commits.

djc commented 6 years ago

Merged! I've also pushed a new release to PyPI, thanks.

I'd like to add you to the AUTHORS file if you don't mind passing me a real email address (or make a PR yourself).

wamuir commented 6 years ago

Sure! Address is wamuir@gmail.com

djc commented 6 years ago

Added in d96073e.