djc / rnc2rng

RELAX NG Compact to regular syntax conversion library
MIT License
16 stars 13 forks source link

Fix annotation and namespace issue (continued) #44

Closed jombr closed 5 months ago

jombr commented 5 months ago

Continue the work of #19 to fix #16

Fixes #16, and a variety of other issues hit in processing my existing grammars to extract documentation

  • Support documentation (or any other annotations) on groups and references to a named define
  • use a: as the xmlns prefix for http://relaxng.org/ns/compatibility/annotations/1.0, but don't assume that the user has already defined it, and make sure to qualify the case where they defined namespace a=... to be something else too.
  • Follow the spec for whitespace handling in a:documentation
  • Fix combining |=, &= productions in the presence of annotations.
  • Fix handling of datatag and literals with possibly-namespaced type references.

Additional changes:

grammar level datatypeLibrary solution

Changes in addition to discussed solution

djc commented 5 months ago

Do you want to take over maintenance?

https://github.com/djc/rnc2rng/issues/41

jombr commented 5 months ago

Do you want to take over maintenance?

41

I'm willing to but there may be quite a bit with the code base, Continuous Integration, and Deployment to PiPy that I'm not familiar with. That and I started learning Python this year while only visiting relaxng off and on.

That being said I'm interested, enjoy learning, and the package seems pretty stable. If your comfortable with that and can be available for questions then I'll do it.

djc commented 5 months ago

I've invited you as a collaborator on this repository. Let's see how this works out? Since you're indicating that you're pretty new to things I'll withhold PyPI permissions for now -- feel free to ask questions.

jombr commented 5 months ago

I've invited you as a collaborator on this repository. Let's see how this works out? Since you're indicating that you're pretty new to things I'll withhold PyPI permissions for now -- feel free to ask questions.

Alright! I have some reading to do.

Let me know if this PR works for you (If you think its aligned with what @puetzk had in mind).

If this PR checks out I'll probably re-base it after #45 lands.

coveralls commented 5 months ago

Coverage Status

coverage: 89.527% (+0.6%) from 88.963% when pulling 12073d925a2b7d984aa1e095f329717dc3838942 on josephbredahl:annotations into 813bc863f29ce13e005ec95ab3d3bd3b7beef411 on djc:main.

djc commented 5 months ago

Sorry, I won't have time to thoroughly review this PR -- happy to answer any specific questions you have, though!

jombr commented 5 months ago

No worries, figured it could be rude if I pushed without asking for a review. I'll review it again before merging.

djc commented 5 months ago

Not rude, I'm considering you the primary maintainer from here on, though I'll still want to check before we publish to PyPI.