search

djc / rnc2rng

RELAX NG Compact to regular syntax conversion library
MIT License
16 stars 13 forks source link

Use GITHUB_TOKEN per coveralls 3.3.1 help #45

Closed jombr closed 5 months ago

jombr commented 5 months ago

Getting the following error

Running on Github Actions but GITHUB_TOKEN is not set. Add "env: GITHUB_TOEKN: ${{ secrets.GITHUB_TOKEN }}" to your step config.

Following directions from latest coveralls python (3.3.1) help for Github Actions https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-support

coveralls commented 5 months ago

Coverage Status

coverage: 88.963%. remained the same when pulling 42ea74fed4f99b0e20bddcd60dc17114f2b6287d on josephbredahl:coveralls-token-crash into c70fbc1b11938af3e21ad275904e07d324b8ac08 on djc:main.

jombr commented 5 months ago

@djc this seems to be the right or most popular answer. Let me know if you are OK with swapping using COVERALLS_REPO_TOKEN with the GITHUB_TOKEN.

Otherwise, I'm not really sure why COVERALLS_REPO_TOKEN wasn't working. I expect it should have been brought in via load_config_from_environment.

I couldn't quite verify if setting COVERALLS_REPO_TOKEN within the shell run: | no longer worked. So maybe doing something like...

env:
        COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}

... would still work.

...So I just defaulted to do what the coveralls-python help suggested. Figured that was the most safe path forward.

Also, let me know if you do or don't want me to bug you with reviews.