Closed estriv closed 2 years ago
Is it possible to also add some generic interface for unknown X-
extensions, so imap-proto
does not have to grow support for every non-standard extension?
Somewhat related PR, Delta Chat ignores [Gmail]
folders mapped to these labels: https://github.com/deltachat/deltachat-core-rust/pull/2587
Yes this would be possible implementing a type for MailboxDatum
and AttributeValue
that holds a tag name (like "GM-LABELS" oder "GM-THRID") and a variant on a list, string or number. But this, in my eyes, breaks with the design choices of imap-proto as it softens the typing.
@djc What can I do?
Have a little patience and not expect me to review your changes immediately when it's Christmas? 😛
Sorry, I thought I messed something up...
Well, you should also run cargo fmt on your changes, looks like.
I already did this yesterday and pushed the changes: https://github.com/estriv/tokio-imap/commit/365c6e6971a288bfab9942bb92020e906193ebd9
Well, that commit doesn't exist on your PR branch.
Hi,
I was using your crate to interact with the Google IMAP server. As I heavily rely on Google's IMAP extensions I started implementing them with X-GM-LABELS.
I would be glad if you accept the changes. Further implementation will be done as I find time and the need.