djc / tokio-imap

Tokio-based IMAP implementation
Apache License 2.0
123 stars 42 forks source link

Add support for google x-gm-msgid extension #148

Closed lancel0 closed 1 year ago

lancel0 commented 1 year ago

Add support for the X-GM-MSGID extension

Gmail provides a unique message ID for each email so that a unique message may be identified across multiple folders.

I made changes similar to https://github.com/djc/tokio-imap/pull/138 and https://github.com/jonhoo/rust-imap/pull/225 then tested that msg ids were correctly fetched from google.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 67.85% and project coverage change: -0.09 :warning:

Comparison is base (00defc1) 78.91% compared to head (59f56fb) 78.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #148 +/- ## ========================================== - Coverage 78.91% 78.82% -0.09% ========================================== Files 24 24 Lines 3618 3646 +28 ========================================== + Hits 2855 2874 +19 - Misses 763 772 +9 ``` | [Impacted Files](https://app.codecov.io/gh/djc/tokio-imap/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dirkjan+Ochtman) | Coverage Δ | | |---|---|---| | [imap-proto/src/builders/command.rs](https://app.codecov.io/gh/djc/tokio-imap/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dirkjan+Ochtman#diff-aW1hcC1wcm90by9zcmMvYnVpbGRlcnMvY29tbWFuZC5ycw==) | `69.88% <0.00%> (-0.27%)` | :arrow_down: | | [imap-proto/src/types.rs](https://app.codecov.io/gh/djc/tokio-imap/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dirkjan+Ochtman#diff-aW1hcC1wcm90by9zcmMvdHlwZXMucnM=) | `16.58% <0.00%> (-0.09%)` | :arrow_down: | | [imap-proto/src/parser/gmail.rs](https://app.codecov.io/gh/djc/tokio-imap/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dirkjan+Ochtman#diff-aW1hcC1wcm90by9zcmMvcGFyc2VyL2dtYWlsLnJz) | `76.92% <73.91%> (-2.39%)` | :arrow_down: | | [imap-proto/src/parser/rfc3501/mod.rs](https://app.codecov.io/gh/djc/tokio-imap/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dirkjan+Ochtman#diff-aW1hcC1wcm90by9zcmMvcGFyc2VyL3JmYzM1MDEvbW9kLnJz) | `96.26% <100.00%> (+0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.