Closed link2xt closed 9 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
2c8f6cb
) 79.00% compared to head (8e4faea
) 79.05%.
Files | Patch % | Lines |
---|---|---|
imap-proto/src/parser/rfc5464.rs | 86.66% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
BTW I'm open to PRs that make the parser recoverable where possible.
BTW I'm open to PRs that make the parser recoverable where possible.
I just don't know how to do this, probably the best way is to add last-resort garbage parser that tries to skip one unknown response if all other parsers fail.
IIRC it's probably possible to impose some meta structure that just looks for \r\n
and knows how to work around DATA
blocks so it can recover to the next \r\n
.
map_opt always fails if second argument returns None.