search

djc / tokio-imap

Tokio-based IMAP implementation
Apache License 2.0
123 stars 42 forks source link

Allow variable number of spaces in RFC 2087 parser of quota_resource #169

Closed link2xt closed 5 months ago

link2xt commented 5 months ago

Archiveopteryx 3.2.0 incorrectly generates two spaces between numbers.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.78%. Comparing base (0aeb02e) to head (9958324).

Files Patch % Lines
imap-proto/src/parser/rfc2087.rs 95.45% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #169 +/- ## ========================================== + Coverage 78.72% 78.78% +0.06% ========================================== Files 22 22 Lines 3568 3583 +15 ========================================== + Hits 2809 2823 +14 - Misses 759 760 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djc commented 5 months ago

Please tell your OP to file bugs against this crappy server.

link2xt commented 5 months ago

The bugs are actually fixed already: https://github.com/deltachat/deltachat-core-rust/issues/5513 Problem is that latest release (3.2.0) is from 2014-03-10 so fixing these bugs requires compiling from git.

djc commented 5 months ago

Oh, that's great to hear! Want to submit a PR to bump the version number? Happy to put out a release soon.

link2xt commented 5 months ago

Want to submit a PR to bump the version number? Happy to put out a release soon.

https://github.com/djc/tokio-imap/pull/170