search

djc / tokio-imap

Tokio-based IMAP implementation
Apache License 2.0
123 stars 42 forks source link

imap-proto/parser: add HIGHESTMODSEQ status attribute #28

Closed dario23 closed 6 years ago

dario23 commented 6 years ago

the HIGHESTMODSEQ attribute is specified in https://tools.ietf.org/html/rfc4551. although this doesn't aim to implement that rfc to any level of completion, i needed this basic level of support because some servers (dovecot in my case) always send HIGHESTMODSEQ-responses with STATUS lines

djc commented 6 years ago

Makes sense, thanks for patching it in! Rebased as 5bd95ca205de1c3c295f165f3813c46ee3013f91 and applied a tiny bit of polish in 715eaeff6333a07be0d3a5084db23f6f2b4bf6f5. (I've also taken care of the problems that made CI fail.)

dario23 commented 6 years ago

just noticed that in my PR AttributeValue::HighestModSeq has an u32 value, whereas rfc 4551 and the other code say it should be u64. i'm not sure how to reopen a PR/if i'm allowed to do that at all, but maybe you could just commit the fix yourself or cherry-pick from my repo :-)

djc commented 6 years ago

Easiest for me would be if you can rebase your fix on top of master and submit a new PR would you mind doing that?

djc commented 6 years ago

Note that you probably also need to change the parser for this.

dario23 commented 6 years ago

29 :-)