search

djc / tokio-imap

Tokio-based IMAP implementation
Apache License 2.0
123 stars 42 forks source link

Refactoring documentation tests #38

Closed duesee closed 5 years ago

duesee commented 5 years ago

Okay, I hope I've done this right. I think it is now reviewable.

djc commented 5 years ago

If you make it pass CI, I'll gladly merge it. Thanks!

duesee commented 5 years ago

I will remove the new unit test then. You can merge the refactorings and I will open another PR when I found how to fix the streaming issue. Nom's escaped macro worked for my test but broke others.

duesee commented 5 years ago

text is still erroneous. It should only accept 01-7f and not CR or LF.

djc commented 5 years ago

I squashed together your intermediate changes, left out the commented out test, fixed the compile warnings and merged the resulting commits to master:

8c0476e corrected text parser + text_char parser 11fe932 moved text parser to core and added ABNF d797bd8 ABNF definitions from IMAP RFC 1f2b8e5 refactored "core" parsers

djc commented 5 years ago

Thanks!