Parsing of the metadata response (RFC5464)

djc / tokio-imap

Tokio-based IMAP implementation

Apache License 2.0

123 stars 42 forks source link

Parsing of the metadata response (RFC5464) #59

Closed Sergey-Kitov closed 5 years ago

Sergey-Kitov commented 5 years ago

Implementation of METADATA extension response parser

djc commented 5 years ago

Thanks for working on this!

Functionally this looks pretty okay. Would you mind reformatting it a bunch so that the style within the macro calls looks more like rustfmt-formatted code? Notably:

Opening braces for if conditions go on the same line
Max line length at 100 characters
Closing brace for multi-line blocks on its own line (possibly with comma, but not at the last line of the block
Spaces inside braces for structs on the same line

Sergey-Kitov commented 5 years ago

Does it look better now?

Sergey-Kitov commented 5 years ago

I have implemented all rustfmt corrections for non macro invocation code.

djc commented 5 years ago

Thanks!

Sergey-Kitov commented 5 years ago

Thank you very much!