search

djc / tokio-imap

Tokio-based IMAP implementation
Apache License 2.0
123 stars 42 forks source link

Refactoring modules into `parser::` and `types::` + minor cleanups #80

Closed duesee closed 4 years ago

duesee commented 4 years ago

I also added an example, so that someone who is unsure wheather to use this library or not can see what it does.

duesee commented 4 years ago

Thank you for the feedback! Makes all sense :-) There is only one problem... I have no idea how to split commits in a PR. Should I close this one first? I will try tomorrow evening.

djc commented 4 years ago

I usually use git rebase -i to do an interactive rebase. If you set that to edit the offending commit, you can then git reset HEAD^ to reset the branch pointer to the previous commit while keeping your changes, so you can make new commits with git commit -p or similar.

duesee commented 4 years ago

Okay, I think I learned how to squash, rearrange and split commits :-) See #81. I added 3 more commits here which you can review. Otherwise the new branch is identical to this one. Just so you don't have to review anything twice.