search

djcas9 / komanda

The IRC Client For Developers
http://komanda.io
MIT License
1.78k stars 75 forks source link

Use sass/less/etc #121

Open tyscorp opened 10 years ago

tyscorp commented 10 years ago

This would make creating themes a LOT easier, as you'd only have to tweak a few colours in most cases.

MoOx commented 10 years ago

Does node-webkit already have CSS variables ?

eugene-bulkin commented 10 years ago

@MoOx even if it does, e.g. SASS provides useful functionality that won't ever be in CSS officially anyway.

I personally use SCSS all the time and would have no problem with using a preprocessor but unless it's 100% necessary (it may be, the CSS can get kinda verbose at times) we don't have to do this right now.

MoOx commented 10 years ago

@eugene-bulkin fyi, it's Sass, not SASS. I used to use Sass everywhere, but now I'm using a good naming convention, and the only things I miss are variables (because now, we do have math, thanks to calc). But now I use myth, a futurproof way to use native CSS syntax, even if not totally implemented in all browsers.

And for theming something like Komanda, using simples variables should be more than enough.

eugene-bulkin commented 10 years ago

That's true, but mixins are also very useful. I don't really care either way.

djcas9 commented 10 years ago

My opinion may be pretty unpopular but I don't care much for abstractions. If you use css classes properly I don't really see the purpose in variables, mixins etc. I look at sass/less etc like I look at coffeescript.. pointless crap push on the community via rails.

Also,, the whole nested css selector stuff is a nightmare to me.

djcas9 commented 10 years ago

With that said.. if the community wants it thats another story.. if variables will make themeing easier.. maybe we just create a boilerplate css templates people can use?